Support retrying failed messages for rate limit on Twilio WhatsApp #733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #733 +/- ##
=======================================
Coverage 74.57% 74.57%
=======================================
Files 110 110
Lines 13277 13280 +3
=======================================
+ Hits 9901 9904 +3
Misses 2664 2664
Partials 712 712 ☔ View full report in Codecov by Sentry. |
rowanseymour
requested changes
Apr 22, 2024
| @@ -207,6 +208,9 @@ func (h *handler) receiveStatus(ctx context.Context, channel courier.Channel, w | |||
| } | |||
| } | |||
| clog.Error(twilioError(errorCode)) | |||
| if errorCode == errorThrottled { | |||
| status = h.Backend().NewStatusUpdateByExternalID(channel, form.MessageSID, courier.MsgStatusErrored, clog) | |||
There was a problem hiding this comment.
I thought we got rid of handlers creating status updates? This won't be used no? The sender creates the status update.
There was a problem hiding this comment.
In this case the status is reported to use asynchronously so the handler still need set the status to error so we can retry in this case
We changed for the Send method only
rowanseymour
approved these changes
Apr 22, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.